Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the repo - more collaborators or rise of the bots? #48

Open
hawkins opened this issue Feb 20, 2018 · 5 comments
Open

State of the repo - more collaborators or rise of the bots? #48

hawkins opened this issue Feb 20, 2018 · 5 comments
Assignees

Comments

@hawkins
Copy link
Member

hawkins commented Feb 20, 2018

It's become painfully apparent that I don't have the time to maintain this list with the care it needs now.

I see two approaches to fix this:

  • Trivially bring on more awesome folks to manually approve / reject link changes
  • Or write a GitHub bot (probot?) that can PR links that users provide in Issues

Personally I'm a big fan of the bot approach - could save on a lot of man hours in the future, so we can all spend our time solving more interesting tasks than editing readme files all evening. I'd be happy to work on this task, since I could do this during my live streams I'm trying to start this week, so readers and viewers could follow along and contribute too. 👍

@hawkins
Copy link
Member Author

hawkins commented Feb 20, 2018

cc @mweststrate ; would love your thoughts on this :)

@mweststrate
Copy link
Member

@hawkins a bot would actually be pretty cool! Even just to find out whether that works it sounds valuable :)

@hawkins
Copy link
Member Author

hawkins commented Feb 24, 2018

Sounds good! I'm investigating the effort now, and have started brainstorming a bit over on the project. Hoping to live stream work on this sometime this weekend!

@hawkins
Copy link
Member Author

hawkins commented Mar 3, 2018

Looks like this is a very feasible option! I have already managed to create commits and PRs when a user opens an issue and provides a link, or close it if its a duplicate link.

There's some fine tuning to do and translation still, but looks like this could be a very handy tool!

@hawkins hawkins self-assigned this Mar 3, 2018
@hawkins
Copy link
Member Author

hawkins commented Nov 15, 2018

The bot's officially ready production and able to handle issues with a link in the body. 🎉 (All that's left is another MobX admin approving a request to add the bot to this repo)

While it doesn't do everything I wanted it to yet, i.e. it doesn't add flavor text to the link in the readme, that can be easily edited after the fact. This means, the following workflow is now possible and easy:

  • Reader opens a new issue to add a new link (Any issue with an http/s link in the body is considered for this purpose)
  • MobX bot automatically opens a PR with this link added to the appropriate section (in most cases, though bound to be the buggies part of the code)
  • Member of MobX organization can edit the file in the branch the bot made for the automatic PR to add any flavor text as desired
  • Member of MobX organization can merge whenever desired
  • Original issue is automatically closed by GitHub due to "fixes issue" text in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants