Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor drupal-tabs component to avoid chaining selectors #27

Open
carwin opened this issue Aug 18, 2020 · 1 comment
Open

Refactor drupal-tabs component to avoid chaining selectors #27

carwin opened this issue Aug 18, 2020 · 1 comment

Comments

@carwin
Copy link
Contributor

carwin commented Aug 18, 2020 •
edited
Loading

Currently the drupal-tabs component has chained selectors pointing to tag selectors.

To decrease the specificity of these declarations, refactor by adding classes to the child li and a elements.

E.g.,

.drupal-tabs--secondary > li > a

would be better as

.drupal-tabs__item-link--secondary

See #26 for the introduction of these selectors.
@carwin
Copy link
Contributor Author

carwin commented Nov 16, 2020

@leo-mobomo here's another code debt task that needs to be done to clean things up.

@fsierra fsierra mentioned this issue May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carwin @leo-mobomo