Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using string as easing function name in 'via' does not work #27

Open
eysteinn opened this issue Sep 14, 2021 · 6 comments
Open

Using string as easing function name in 'via' does not work #27

eysteinn opened this issue Sep 14, 2021 · 6 comments
Assignees

Comments

@eysteinn
Copy link

The code given as example in tween.h:

auto tween = tweeny::from(0.0f, 100.0f).to(100.0f, 0.0f).via(tweeny::easing::linear, "backOut");

results in a compilation error.

@mobius3 mobius3 self-assigned this Sep 19, 2021
@mobius3
Copy link
Owner

mobius3 commented Sep 19, 2021

Can you try 01d3e84?

@Arcnor
Copy link

Arcnor commented Jun 20, 2024

@mobius3 I've had a similar issue today using this library (I'm not using string forms, but for some reason it started complaining about string later). Will it be possible to cut a new release with the latest commits, so package managers can update their versions?

Thanks in advance.

@mobius3
Copy link
Owner

mobius3 commented Jun 20, 2024

I'm actually inclined to removing via with strings altogether. The use case was having it being set when those values comes from configuration files but it has caused more problems than solutions. Ideally this week I'll remove that and push a new release.

@Arcnor
Copy link

Arcnor commented Jun 20, 2024

I'm actually inclined to removing via with strings altogether. The use case was having it being set when those values comes from configuration files but it has caused more problems than solutions. Ideally this week I'll remove that and push a new release.

Yeah, whoever needs that can probably just do the switch themselves with the values they need anyway :).

Thanks!

@Arcnor
Copy link

Arcnor commented Jul 26, 2024

I'm actually inclined to removing via with strings altogether. The use case was having it being set when those values comes from configuration files but it has caused more problems than solutions. Ideally this week I'll remove that and push a new release.

Hey there @mobius3 , have you found the time to do this change? If you haven't, do you need help with it? Not sure if the fix is just remove the whole function altogether or something else, but I can open a PR if it helps.

Thanks again!

@mobius3
Copy link
Owner

mobius3 commented Jul 31, 2024

Huh, "this weekend", yeah. Sorry, life is taking all of me :P I'm willing to work together in a PR and accept it, indeed. The fix is just to nuke whatever string version of via there is, yes. Thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants