-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only write supported unit names, especially avoid non UTF-8 characters #74
Comments
I'll look into this - link this issue: mobie/mobie-viewer-fiji#583 |
Thanks for linking the issue.
Right now I am also not handling this at all in python, I made an issue to keep track of this: mobie/mobie-utils-python#41 and I will try to use functionality from ome-zarr-py / maybe contribute it myself.
Yes, I also do not constrain this right now. It would indeed be good to think about this, I am not sure what's the best approach right now... |
I think this is implemented already, correct @K-Meech? |
Yes - this is done already. If possible, it converts the unit to one of the approved OME-ZARR units. |
It would be good to only write unit names that are recommended in the v0.4 spec, see https://github.com/ome/ngff/blob/main/0.4/index.bs#L228-L229.
I understand that this is a bit tricky, since the unit names are read from the image metadata in Fiji, but we can add a dict with common translations and then throw a warning if no match is found.
It would be especially important to write
micrometer
instead of$\mu$m
, to stick with simple string encoding; this otherwise might break implementations that only support utf-8.(There might be an issue on this topic already, but I couldn't find it.)
The text was updated successfully, but these errors were encountered: