Create primary key for new tables #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Oct 23, 2024
| schema=schema, | ||
| if_exists='replace', | ||
| ) | ||
| # table was just created, create primary key (to_postgis doesn't create these, |
There was a problem hiding this comment.
We're calling to_sql() above, not to_postgis(). Can you expand the comment to explain what's going on?
There was a problem hiding this comment.
Added a comment that explains that GeoDataFrame's methods are not named in a db agnostic as pandas.DataFrame's to_sql.
derhuerst
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
- Does
con.connection.cursor()start a new transaction? What if it fails? What if we're already within a transaction? PostgreSQL doesn't allow nested transactions.
I don't know if the with closing(con.connection.cursor()) as c expressions each open a new connection to the DB. If they do, they won't run in the same transaction because AFAIK transactions are always connection-bound.
Assuming that it works as-implemented, I approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
GeoDataFrame.to_postgis(...index=True)does not create them)replaceaction drops the table and recreates it (see to_postgis). Helpful would be, if replace would implement truncate/insert and a not-yet-existing optionrecreatewould drop and create the table...)