Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow applying modulations to recorded waves #66

Open
CBluesF opened this issue Feb 18, 2024 · 2 comments
Open

Allow applying modulations to recorded waves #66

CBluesF opened this issue Feb 18, 2024 · 2 comments
Assignees

Comments

@CBluesF
Copy link

CBluesF commented Feb 18, 2024

Is your feature request related to a problem? Please describe.
Once a recording has been made it is fixed in place and e.g. the amplitude cannot subsequently be changed, wavefolding cannot be applied, etc.

Describe the solution you'd like
Allow functions to be applied to an already recorded wave, as if the recording was an input.

Potential ramifications or implications
If this was on by default, recording a wave while modulations are running (to "save" those modulations) would then apply them again once the recording is done. I would suggest having this as a toggleable option, off by default, to avoid that. Alternatively, the modulations active for the unrecorded wave could save and a fresh set open up for editing while the recording is playing.

This can currently be done using two channels - the first with a recording and the second set to "Out" with the first channel as the selected output.

@cardinal-bin
Copy link

There's a potential interesting option here for what happens when pressing record again - a nice option would be to allow the modulated recording to be recorded itself, overdubbing the existing recording (and again, resetting the modulations to avoid doubling up).

So we could go from: modulated wave => fixed recording of modulated wave => modulated recording => fixed recording of previous modulated recording.

@ost-ing
Copy link
Contributor

ost-ing commented Jul 9, 2024

I thought about this a while ago when I first implemented the recorder and decided against it to try to maintain simplicity. With the out channel this functionality can be achieved (although it will use 2 channels rather than just 1), so I'm leaning towards leaving it how it is, at least for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants