Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress test for ImmixAllocator should not change limits of the allocator #1201

Open
k-sareen opened this issue Sep 17, 2024 · 1 comment
Open

Comments

@k-sareen
Copy link
Collaborator

When I fixed stress test for ImmixAllocator I implemented require_new_block in a way that had a side-effect of attempting to recycle lines/blocks. Back then I thought this wouldn't cause issues but I believe I've recently triggered a bug in my port that is caused by this. Ideally the stress test should be side-effect free. The issue is that the current code isn't architected in a way that makes it easy to do. For example, the associated ImmixSpace may end up popping recyclable blocks and update the hole searching line field in the current implementation.

@k-sareen k-sareen changed the title Stress test for ImmixAllocator should not attempt to recycle lines/blocks Stress test for ImmixAllocator should not change limits of the allocator Sep 17, 2024
@qinsoon
Copy link
Member

qinsoon commented Sep 18, 2024

I don't quite get this. Can you explain what is the expected behavior, and what is the wrong behavior you observed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants