Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more optimal implementation for finding base references #1193

Open
qinsoon opened this issue Sep 2, 2024 · 0 comments
Open

A more optimal implementation for finding base references #1193

qinsoon opened this issue Sep 2, 2024 · 0 comments
Labels
A-obj-metadata Area: Object Metadata (headers, side tables) C-enhancement Category: Enhancement

Comments

@qinsoon
Copy link
Member

qinsoon commented Sep 2, 2024

We currently use SideMetadata::find_prev_non_zero_value to find the base reference for an internal reference. The implementation of SideMetadata::find_prev_non_zero_value is fully general for all kinds of side metadata, and does not use any specific assumption about object references. In our discussion for #1192, Steve mentioned that we may be able to implement a more optimal implementation of finding base references. For example, if we assume the returned address will be an aligned object reference, we don't need the filtering in #1192. There might be other opportunities for optimization. We need further discussion to decide what we can optimize.

@qinsoon qinsoon added C-enhancement Category: Enhancement A-obj-metadata Area: Object Metadata (headers, side tables) labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-obj-metadata Area: Object Metadata (headers, side tables) C-enhancement Category: Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant