Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option as a Parameter List? #455

Open
Xaldew opened this issue Oct 29, 2024 · 0 comments
Open

Option as a Parameter List? #455

Xaldew opened this issue Oct 29, 2024 · 0 comments

Comments

@Xaldew
Copy link

Xaldew commented Oct 29, 2024

In PBRT-v4, the "Option" keyword was introduced to set miscellaneous options. Typically, I have been able to treat all rendering options as parameter lists, but this particular one seems to break that pattern.

As far as I have been able to tell from the PBRT-v4 source code (pbrt/parser.cpp:877), it is only valid to set these sequentially, i.e.:

Option "string seed" [123]
Option "bool pixelstats" [true]

However, given that PBRT-v4 is still under active development, perhaps it would make sense to also support treating the options themselves as a parameter list? I.e., allowing something like this:

Option "string seed" [123] "bool pixelstats" [true]

Not sure that this would help in any specific regard, but it would at least allow treating the file format in a more unified way.

Also, is there any example files out there that actually use these options? I couldn't find any among the PBRT-v4 example scenes (https://github.com/mmp/pbrt-v4-scenes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant