Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be "area density" instead of "solid angle density" in the book? #10

Open
Enigmatisms opened this issue Feb 26, 2023 · 0 comments

Comments

@Enigmatisms
Copy link

In PBR-book chapter 16.3, when the book is introducing the function PdfLightOrigin, it says:

<<Return solid angle density for non-infinite light sources>>

The returned value is directly assigned to some_vertex.pdfFwd. Since pdfFwd field in the vertex should store density defined in area measure for MIS uses. Some implementation of Pdf_Le (which returns pdf_pos and is directly used in PdfLightOrigin) also indicate this, for example, diffusive area source returns pdf_pos = 1 / Area().
Upon first reading this, I directly implemented PdfLightOrigin to return solid angle density for all light sources, but latter I think it doesn't make any sense... Could this be a mistake? Like, it were copy-pasted from the introduction of infinite light source procedure above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant