-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe there are some typos #1
Comments
pbr-book-website/3ed-2018/Shapes/Triangle_Meshes.html Lines 213 to 215 in 02b496a
Maybe there is another typo: I guess you meant "the number of edges and faces ... " |
pbr-book-website/3ed-2018/Shapes/Triangle_Meshes.html Lines 2496 to 2497 in 02b496a
pbr-book-website/3ed-2018/Shapes/Triangle_Meshes.html Lines 2508 to 2509 in 02b496a
Maybe Figure 3.14 and its caption are inconsistent with the text. It should be: |
Maybe you mean that "......the |
It should be "e=255" rather than "e_b=255". |
https://github.com/mmp/pbr-book-website/blob/02b496ae12670f8ffec2a6fe67cc30b07e57cba6/3ed-2018/Shapes/Managing_Rounding_Error.html#L8932 |
Hi @kanition,
I recommend shooting them an email with this issue linked, if you haven't already. |
Thank you for your advice. I'll try it. |
pbr-book-website/3ed-2018/Shapes/Other_Quadrics.html
Line 1355 in 02b496a
I really like this amazing work and thank you for your sharing this book!
I have a problem with the implicit form of the hyperboloid:
It is x^2+y^2-z^2=-1, which means that it is a two-sheet hyperboloid.
But the parametric form shows that it is generated by a rotating line passing through points (x1,y1,z1) and (x2,y2,z2),
which should be a one-sheet hyperboloid.
Maybe the implicit form of the hyperboloid should be changed to x^2+y^2-z^2=1 for consistency.
Reference:https://en.wikipedia.org/wiki/Hyperboloid
The text was updated successfully, but these errors were encountered: