Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String property values are not inspectable #19

Open
yantar92 opened this issue Mar 9, 2023 · 12 comments
Open

String property values are not inspectable #19

yantar92 opened this issue Mar 9, 2023 · 12 comments

Comments

@yantar92
Copy link
Contributor

yantar92 commented Mar 9, 2023

To reproduce:

(inspector-inspect (propertize "foo" 'data '#1=(1 #1#)))
@mmontone
Copy link
Owner

mmontone commented Mar 9, 2023

Will add soon. Thanks for reporting.

mmontone added a commit that referenced this issue Mar 9, 2023
@mmontone
Copy link
Owner

mmontone commented Mar 9, 2023

Strings text properties are inspectable now

@mmontone
Copy link
Owner

mmontone commented Mar 9, 2023

Using object-intervals now.

@yantar92
Copy link
Contributor Author

Note that object-intervals is only available since Emacs 28.

@mmontone
Copy link
Owner

Ok. Do you have suggestion of what to do for Emacs < 28 ?

@yantar92
Copy link
Contributor Author

No great ideas, unfortunately. I just know an ugly workaround. See https://git.savannah.gnu.org/cgit/emacs/org-mode.git/tree/lisp/org-fold-core.el#n1450

@mmontone
Copy link
Owner

Ok. I'll have a look. Worst case don't provide text-properties inspection for Emacs < 28.

mmontone added a commit that referenced this issue Mar 11, 2023
Tested using Emacs 27.2. It works.
See issue #19
@mmontone
Copy link
Owner

Implemented it like that and it works. Tested on Emacs 27.2

@yantar92
Copy link
Contributor Author

A small annoyance is that string is not fontified as string.
2023-03-16_13-54

@yantar92
Copy link
Contributor Author

It would also be nice to support some extra features for standard text properties and special symbols:

  1. Function symbols may have an extra button to go to Help buffer. Same for faces, variables, etc
  2. Faces can be fontified as they are defined
  3. Face specs, like background/foreground could be fontified accordingly
  4. Composition can be interpreted as it is done in M-x describe-char

mmontone added a commit that referenced this issue Mar 16, 2023
@mmontone
Copy link
Owner

Good idea.
I don't understand point 4), though.

@yantar92
Copy link
Contributor Author

2023-03-16_14-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants