Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger should be refactored #315

Open
mb706 opened this issue Oct 20, 2024 · 0 comments
Open

ranger should be refactored #315

mb706 opened this issue Oct 20, 2024 · 0 comments

Comments

@mb706
Copy link
Contributor

mb706 commented Oct 20, 2024

There seem to be a few issues in the paramset of ranger

  • "alpha" is present in classif and regr, but according to ranger docs this is only valid for 'maxstat' splitrule, which exists only for survival? Also the case for 'minprop' and likely for some others.
  • 'lower' of max.depth should be '1', not '0'. '0' is a special value, same as NULL, which has different behaviour from other values. Having 0 as part of the non-special-value-range confuses optimizers
  • default of 'respect.unordered.factors' should not be 'ignore', it should not be set (since the default depends on what value 'splitrule' has)

Someone should probably read over this and check for other issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant