From 3c74a42e91807c32bd1e1ce2f8b0d0b1ac006fec Mon Sep 17 00:00:00 2001 From: be-marc Date: Tue, 15 Oct 2024 12:11:01 +0200 Subject: [PATCH 1/3] compatibility: bbotk 1.1.1 --- R/FSelectInstanceBatchMultiCrit.R | 4 +++- R/FSelectInstanceBatchSingleCrit.R | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/R/FSelectInstanceBatchMultiCrit.R b/R/FSelectInstanceBatchMultiCrit.R index a710107c..c67abfd3 100644 --- a/R/FSelectInstanceBatchMultiCrit.R +++ b/R/FSelectInstanceBatchMultiCrit.R @@ -93,7 +93,9 @@ FSelectInstanceBatchMultiCrit = R6Class("FSelectInstanceBatchMultiCrit", #' #' @param ydt (`data.table::data.table()`)\cr #' Optimal outcomes, e.g. the Pareto front. - assign_result = function(xdt, ydt) { + #' @param ... (`any`)\cr + #' ignored. + assign_result = function(xdt, ydt, ...) { # Add feature names to result for easy task subsetting features = map(transpose_list(xdt), function(x) { self$objective$task$feature_names[as.logical(x)] diff --git a/R/FSelectInstanceBatchSingleCrit.R b/R/FSelectInstanceBatchSingleCrit.R index cc1be330..a33572d3 100644 --- a/R/FSelectInstanceBatchSingleCrit.R +++ b/R/FSelectInstanceBatchSingleCrit.R @@ -138,7 +138,9 @@ FSelectInstanceBatchSingleCrit = R6Class("FSelectInstanceBatchSingleCrit", #' #' @param y (`numeric(1)`)\cr #' Optimal outcome. - assign_result = function(xdt, y) { + #' @param ... (`any`)\cr + #' ignored. + assign_result = function(xdt, y, ...) { # Add feature names to result for easy task subsetting feature_names = self$objective$task$feature_names features = list(feature_names[as.logical(xdt[, feature_names, with = FALSE])]) From c546195170c6e54613bbfe66fd475087bdb1f366 Mon Sep 17 00:00:00 2001 From: be-marc Date: Tue, 15 Oct 2024 12:11:53 +0200 Subject: [PATCH 2/3] ... --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index 4cb2d5f6..7c5b2151 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # mlr3fselect (development version) +* compatibility: bbotk 1.1.1 + # mlr3fselect 1.1.0 * compatibility: mlr3 0.21.0 From 75590aaaee88628af2e9f18c0f6ad44ea9b56825 Mon Sep 17 00:00:00 2001 From: be-marc Date: Tue, 15 Oct 2024 12:15:21 +0200 Subject: [PATCH 3/3] ... --- man/FSelectInstanceBatchMultiCrit.Rd | 5 ++++- man/FSelectInstanceBatchSingleCrit.Rd | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/man/FSelectInstanceBatchMultiCrit.Rd b/man/FSelectInstanceBatchMultiCrit.Rd index 82b136df..e584f81b 100644 --- a/man/FSelectInstanceBatchMultiCrit.Rd +++ b/man/FSelectInstanceBatchMultiCrit.Rd @@ -151,7 +151,7 @@ List of callbacks.} The \link{FSelector} object writes the best found feature subsets and estimated performance values here. For internal use. \subsection{Usage}{ -\if{html}{\out{
}}\preformatted{FSelectInstanceBatchMultiCrit$assign_result(xdt, ydt)}\if{html}{\out{
}} +\if{html}{\out{
}}\preformatted{FSelectInstanceBatchMultiCrit$assign_result(xdt, ydt, ...)}\if{html}{\out{
}} } \subsection{Arguments}{ @@ -164,6 +164,9 @@ additional columns for extra information.} \item{\code{ydt}}{(\code{data.table::data.table()})\cr Optimal outcomes, e.g. the Pareto front.} + +\item{\code{...}}{(\code{any})\cr +ignored.} } \if{html}{\out{}} } diff --git a/man/FSelectInstanceBatchSingleCrit.Rd b/man/FSelectInstanceBatchSingleCrit.Rd index fa905387..83091870 100644 --- a/man/FSelectInstanceBatchSingleCrit.Rd +++ b/man/FSelectInstanceBatchSingleCrit.Rd @@ -193,7 +193,7 @@ Ignored if multiple measures are used.} The \link{FSelector} writes the best found feature subset and estimated performance value here. For internal use. \subsection{Usage}{ -\if{html}{\out{
}}\preformatted{FSelectInstanceBatchSingleCrit$assign_result(xdt, y)}\if{html}{\out{
}} +\if{html}{\out{
}}\preformatted{FSelectInstanceBatchSingleCrit$assign_result(xdt, y, ...)}\if{html}{\out{
}} } \subsection{Arguments}{ @@ -206,6 +206,9 @@ additional columns for extra information.} \item{\code{y}}{(\code{numeric(1)})\cr Optimal outcome.} + +\item{\code{...}}{(\code{any})\cr +ignored.} } \if{html}{\out{}} }