Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide downvote button if disabled on instance #1476

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Hide downvote button if disabled on instance #1476

merged 3 commits into from
Dec 4, 2024
+78 −63

Conversation

Sjmarf
Copy link
Contributor

@Sjmarf Sjmarf commented Dec 3, 2024

Closes #1475

@Sjmarf Sjmarf requested a review from a team as a code owner December 3, 2024 10:29
@Sjmarf Sjmarf requested review from JakeShirley and mormaer and removed request for a team December 3, 2024 10:29
EricBAndrews
EricBAndrews approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@EricBAndrews EricBAndrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

One nit re: duplication--should be addressed or dismissed before merge but not important enough to warrant re-review

Mlem/App/Utility/Extensions/Content Models/Comment1Providing+Extensions.swift Outdated Show resolved Hide resolved
@Sjmarf Sjmarf enabled auto-merge (squash) December 4, 2024 10:25
@Sjmarf Sjmarf merged commit 7d2b842 into dev Dec 4, 2024
2 checks passed
@Sjmarf Sjmarf deleted the sjmarf/hide-downvotes branch December 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBAndrews EricBAndrews EricBAndrews approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner automatically assigned from mlemgroup/mlem-dev-team

@mormaer mormaer Awaiting requested review from mormaer mormaer is a code owner automatically assigned from mlemgroup/mlem-dev-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide downvote button if downvotes disabled on instance
2 participants
@Sjmarf @EricBAndrews