Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scoring code to ignore test targets #532

Closed
priyakasimbeg opened this issue Oct 3, 2023 · 1 comment
Closed

Update scoring code to ignore test targets #532

priyakasimbeg opened this issue Oct 3, 2023 · 1 comment
Assignees
@runame
Labels
P1 Launch 2023 High priority issues for October 2023 AlgoPerf Launch

Comments

@priyakasimbeg
Copy link
Contributor

Given the update in the rules to exclude test targets from scoring we should update scoring.py.
Specifically get_index_that_reaches_target should ignore the test target when it gets the index.
@priyakasimbeg priyakasimbeg added the P1 Launch 2023 High priority issues for October 2023 AlgoPerf Launch label Oct 3, 2023
@priyakasimbeg
Copy link
Contributor Author

To be more specific, these lines need to be updated: https://github.com/mlcommons/algorithmic-efficiency/blob/main/scoring/scoring.py#L130-L139

@runame runame self-assigned this Oct 5, 2023
@runame runame mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runame runame

Labels
P1 Launch 2023 High priority issues for October 2023 AlgoPerf Launch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@priyakasimbeg @runame