Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shard_and_maybe_pad_np function #515

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fix shard_and_maybe_pad_np function #515

merged 3 commits into from
Sep 21, 2023

Conversation

runame
Copy link
Contributor

@runame runame commented Sep 19, 2023

This PR

  • removes superfluous code in pad function,
  • always pads to global_batch_size if it is provided -- even if there is no remainder,
  • and fix how pad_size is used in pad function.

@runame runame requested a review from a team as a code owner September 19, 2023 18:13
@github-actions
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg
Copy link
Contributor

Thanks for finding and fixing this issue

@priyakasimbeg priyakasimbeg merged commit a6d06df into mlcommons:dev Sep 21, 2023
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@runame runame deleted the fix-padding branch September 22, 2023 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priyakasimbeg priyakasimbeg priyakasimbeg approved these changes

@pomonam pomonam Awaiting requested review from pomonam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runame @priyakasimbeg