Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate Librispeech code #162

Closed
znado opened this issue Oct 8, 2022 · 1 comment
Closed

Deduplicate Librispeech code #162

znado opened this issue Oct 8, 2022 · 1 comment

Comments

@znado
Copy link
Contributor

znado commented Oct 8, 2022

Right now the two Librispeech Jax workloads have some duplicate components, we should have deepspeech import the conformer versions.

We should also clearly document in the data pipeline and in multiple places in the workload that the paddings are inverted so that submitters are less confused.

@znado znado changed the title Deduplicate Librispeech Code Deduplicate Librispeech code Oct 8, 2022
@priyakasimbeg
Copy link
Contributor

I refactored part of the Deepspeech code to fix a bug where Deepspeech where Deepspeech was unintentionally inheriting some Conformer workload properties. Won't fix any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants