Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-navigation and non-fixed app bar indent when scrolling down #1101

Closed
bubblekovrik opened this issue Apr 1, 2021 · 2 comments · Fixed by #1141
Closed

Mini-navigation and non-fixed app bar indent when scrolling down #1101

bubblekovrik opened this issue Apr 1, 2021 · 2 comments · Fixed by #1141
Milestone

Comments

@bubblekovrik
Copy link

Description When using mini-navigation, it is 56 pixels down to not overlap the app bar, but when scrolling down without the app bar, it is padded 56 pixels from the top.

Screenshots
image

Sandbox
Here is a small change to the sandbox of the example code to show the problem:
https://codesandbox.io/s/layout-example-configurable-layout-forked-s7vof?file=/src/Demo.jsx

@mlaursen mlaursen added the layout label Apr 1, 2021
@mlaursen mlaursen added this to the v.Unknown milestone Apr 1, 2021
@mlaursen
Copy link
Owner

mlaursen commented Apr 1, 2021

Thanks for reporting this. I think I'll include this fix along with #1082.

A reminder for me when I tackle this:

  • I have a POC available here
  • basically need to wrap the <LayoutNavigation> and <LayoutMain> components in a new div if the appBarProps?.fixed === false
  • the new <div> should have:
    display: grid;
    grid-template-columns: rmd-layout-theme-var(mini-nav-width) 1fr;
  • the LayoutNavigation's container should set overflow: visible and position: initial
  • the LayoutNavigation's <nav> should set:
    height: auto;
    overflow: auto;
    position: sticky;
    top: 0;
  • I'll need to do a few other changes to support the toggleable-mini layout

@mlaursen mlaursen modified the milestones: v.Unknown, v2.8.0 Apr 10, 2021
@mlaursen mlaursen modified the milestones: v2.8.0, v.Unknown Apr 20, 2021
@mlaursen
Copy link
Owner

mlaursen commented May 6, 2021

Quick update -- I mostly have this ready but there are some performance issues when using the toggleable-mini layout that I'm trying to solve. The drawer doesn't animate well and is choppy because of swapping between a grid and the margin-left that gets applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants