Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in AddFiltersToDialog on Windows (nfd_win.cpp) #97

Open
kcloudy0717 opened this issue Jan 20, 2021 · 0 comments
Open

Memory leak in AddFiltersToDialog on Windows (nfd_win.cpp) #97

kcloudy0717 opened this issue Jan 20, 2021 · 0 comments

Comments

@kcloudy0717
Copy link

Compilation Environment

  • OS: Windows
  • Compiler: MSVC
  • Compiler Version: MSVC 1928
  • Build directory used: vs2010
  • Have I attempted to reproduce the problem on the devel branch? Yes

Memory leak in AddFiltersToDialog when deallocating COMDLG_FILTERSPEC

Before the function returns in AddFiltersToDialog, the code frees the allocated memory for specList and its members, but it only does it for the pszSpec but not the pszName. In the for loop there should also be a line for NFDi_Free( (void*)specList[i].pszName );.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant