Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"VERSION" global variable conflict with p5 #60

Open
ziyuan-linn opened this issue Oct 18, 2023 · 1 comment
Open

"VERSION" global variable conflict with p5 #60

ziyuan-linn opened this issue Oct 18, 2023 · 1 comment

Comments

@ziyuan-linn
Copy link
Member

Both p5.js and @tensorflow-models/face-landmark-detection use VERSION as a global variable. This causes p5 to throw a warning that VERSION is a p5-reserved variable. To not cause confusion among the users, the current library uses patch-package to remove the VERSION global variable from the @tensorflow-models/face-landmark-detection file.

This fix prevents p5 from outputting a warning; however, it also modifies the dependency code. We should consider this fix a temporary hack and eventually contact p5 or TensorFlow about this issue.

@lindapaiste
Copy link
Contributor

We may have similar problems with bodyPose. I was seeing warnings regarding variables box and image when working on #87. I swear those are not variables in my code 😝. We should dig in and see where the conflicts are coming from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants