Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Specific Error on Bad Passwords #217

Open
cameron-kranz opened this issue Oct 5, 2024 · 4 comments
Open

More Specific Error on Bad Passwords #217

cameron-kranz opened this issue Oct 5, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@cameron-kranz
Copy link

It would be nice if when registering, the form told you what the password requirements are, or said specifically what is wrong with the entered password if it doesn't meet the criteria because currently it just says "Password does not meet criteria". Also the strong passwords that apple generates (xxxxxx-xxxxxx-xxxxxx) aren't allowed because they can't have a -, so it would be nice if the criteria allowed them.

@cameron-kranz
Copy link
Author

Also could you tell me what the criteria are because I checked the validator but I don't really understand the pattern matching thing it uses

@mkhorasani
Copy link
Owner

Also could you tell me what the criteria are because I checked the validator but I don't really understand the pattern matching thing it uses

The default criteria are as follows:

                                    - Between 8 and 20 characters long.
                                    - Contain at least one lowercase letter.
                                    - Contain at least one uppercase letter.
                                    - Contain at least one digit.
                                    - Contain at least one special character from [@$!%*?&].

@mkhorasani
Copy link
Owner

mkhorasani commented Oct 6, 2024

It would be nice if when registering, the form told you what the password requirements are, or said specifically what is wrong with the entered password if it doesn't meet the criteria because currently it just says "Password does not meet criteria". Also the strong passwords that apple generates (xxxxxx-xxxxxx-xxxxxx) aren't allowed because they can't have a -, so it would be nice if the criteria allowed them.

Excellent idea! I will look into this for the next release. By the way you can pass your own custom Validator object to the Authenticate class to implement this as well.

@mkhorasani mkhorasani added the enhancement New feature or request label Oct 6, 2024
@cameron-kranz
Copy link
Author

Nice, I will look into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants