-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return members in the same given order #29
Comments
Hello again! Has this been fixed/implemented? |
8 months later... No 😕 |
@pawamoy Hmm, I see your preferred solution but wouldn't it make more sense to have the renderer read the members and act accordingly? Especially since the renderer has since added a new sorting option mkdocstrings/mkdocstrings#274 |
@ofek sorry for the late reply 🙇
Unfortunately that is not possible, because mkdocstrings passes the selection options only to the collector, not the renderer. I wouldn't be against a refactor that removes the distinction between these two options groups (no more selection/rendering keys, no more base renderer / base collector classes, just a base handler one that receives all options). Up to the discussion of course. I'll try to come up with a workaround in the next few days (keeping that issue in my saved notifications). Also note that I've been working on a new "collector" which might alleviate this issue. I'll try to move forward on this in the next few days as well. |
This should now be fixed (finally 🥵!), at least with the new Python handler. |
Ah, but we're in the pytkdocs repo here 🤦 |
Is your feature request related to a problem? Please describe.
Feature asked in mkdocstrings: mkdocstrings/mkdocstrings#102 (comment)
Describe the solution you'd like
Describe alternatives you've considered
It's easier to do it in pytkdocs than re-sorting in mkdocstrings: the renderer and collector options are separated, it would be messy to use the collector options in the renderer, and I don't want to duplicate the
members
option in the renderer (nor users want to copy/paste it).The text was updated successfully, but these errors were encountered: