You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This package currently uses secrets for the inverter connection details (host, ip, modbus slave id) only.
Any adjustments users would like to make have to be made directly in the >3000 line main YAML file, often in several places.
The most likely thing to adjust is probably scan_interval and after that, the min/max values for some of the input_numbers.
These configurable settings could be replaced by using secrets.
There are currently only 3 scan intervals being used: 10, 60, 600 (and 86400 in a commented out sensor).
It should be easy to search and replace those with for example sungrow_modbus_scan_frequency_high, sungrow_modbus_scan_frequency_medium, sungrow_modbus_scan_frequency_low, or something like that.
Or perhaps more aligned with the sensors themselves? sungrow_modbus_scan_frequency_power, sungrow_modbus_scan_frequency_voltage, sungrow_modbus_scan_frequency_info, etc. - you get the idea.
This way, users could easily adjust things like this by editing the secrets.yaml file and not having to touch modbus_sungrow.yaml.
Unless they need other changes, that also makes updating to new versions easier.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This package currently uses secrets for the inverter connection details (host, ip, modbus slave id) only.
Any adjustments users would like to make have to be made directly in the >3000 line main YAML file, often in several places.
The most likely thing to adjust is probably
scan_interval
and after that, themin
/max
values for some of theinput_number
s.These configurable settings could be replaced by using secrets.
could easily become a combination of:
and a secrets.yaml entry like this:
There are currently only 3 scan intervals being used: 10, 60, 600 (and 86400 in a commented out sensor).
It should be easy to search and replace those with for example
sungrow_modbus_scan_frequency_high
,sungrow_modbus_scan_frequency_medium
,sungrow_modbus_scan_frequency_low
, or something like that.Or perhaps more aligned with the sensors themselves?
sungrow_modbus_scan_frequency_power
,sungrow_modbus_scan_frequency_voltage
,sungrow_modbus_scan_frequency_info
, etc. - you get the idea.This way, users could easily adjust things like this by editing the secrets.yaml file and not having to touch modbus_sungrow.yaml.
Unless they need other changes, that also makes updating to new versions easier.
Thoughts? :-)
Beta Was this translation helpful? Give feedback.
All reactions