Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dk.ative.docjure.spreadsheet/create-date-format public #107

Open
pablokleene opened this issue Nov 18, 2022 · 0 comments
Open

Make dk.ative.docjure.spreadsheet/create-date-format public #107

pablokleene opened this issue Nov 18, 2022 · 0 comments

Comments

@pablokleene
Copy link

Hello,

Im trying to write the code to stream a jdbc-next result, of typeIReduceInit, row by row during the reduction into a Sheet.

Got this error The maximum number of Cell Styles was exceeded. You can define up to 64000 style in a .xlsx Workbook.
Looking into this repo, I've found this PR that fixes the problem by memoizing the date creation, but only if Im using add-rows!.

(binding [xls/create-date-format (memoize xls/create-date-format)]
  (reduce (fn [_ row]
            (xls/add-row! sheet row))
          nil
          result))

I tried to do the same wrapping in my code but create-date-format is a private var and I can reference it from the outside.
I achieved what I wanted copying the code to my namespace and overriding dk.ative.docjure.spreadsheet/set-cell with (defmethod dk.ative.docjure.spreadsheet/set-cell! Date ... but I was wondering if this one could be made public

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant