Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_csv_include_input_csv and ignore_csv_columns don't play nicely together #802

Open
mjordan opened this issue Jul 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mjordan
Copy link
Owner

mjordan commented Jul 16, 2024

When output_csv_include_input_csv and ignore_csv_columns are both present in the config file, the field names that are in the ignore_csv_columns list are included in the output CSV but their values are empty, regardless of whether they are empty in the input CSV. Also, only valid Drupal field names appear in the output CSV. In order to support integration with other systems, non-Drupal field names present in the ignore_csv_columns list should also appear in the output CSV.

@mjordan mjordan added the bug Something isn't working label Jul 16, 2024
@mjordan mjordan self-assigned this Jul 16, 2024
@mjordan
Copy link
Owner Author

mjordan commented Jul 16, 2024

The data in the input_csv_row argument to write_to_output_csv() already has the columns listed in ignore_csv_columns removed so we'll need to figure out a way to access the raw (i.e. prior to those columns being removed) input CSV in order to put them back into the output CSV.

@mjordan
Copy link
Owner Author

mjordan commented Jul 17, 2024

This feature needs a little attention. For example, should the "base fields" be included in the output CSV? Should the raw values from the input CSV, or the serialized values from the node fields (as is currently the case) be included in the output CSV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant