Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add members to teams with Slack #10

Open
victorb opened this issue Apr 30, 2015 · 9 comments
Open

Can't add members to teams with Slack #10

victorb opened this issue Apr 30, 2015 · 9 comments

Comments

@victorb
Copy link

victorb commented Apr 30, 2015

Using hubot with Slack adapter and it's not possible to add members to a team, which means the standups cannot be started...

Logs:

[Thu Apr 30 2015 15:43:31 GMT+0200 (CEST)] DEBUG Received message: 'victor is a member of devs' in channel: victor, from: victor
[Thu Apr 30 2015 15:44:28 GMT+0200 (CEST)] DEBUG Received message: '@victor is a member of devs' in channel: victor, from: victor
[Thu Apr 30 2015 15:44:40 GMT+0200 (CEST)] DEBUG Received message: '“Victor Bjelkholm - Typeform” is a member of devs' in channel: victor, from: victor
[Thu Apr 30 2015 15:44:41 GMT+0200 (CEST)] DEBUG Received message: 'standup?' in channel: victor, from: victor
[Thu Apr 30 2015 15:44:41 GMT+0200 (CEST)] DEBUG Message 'typedbot standup?' matched regex //^\s*[@]?typedbot[:,]?\s*(?:standup\?? *$)/i/
[Thu Apr 30 2015 15:44:41 GMT+0200 (CEST)] DEBUG Sending to victor: <who> is a member of <team> - tell hubot who is the member of <team>'s standup
standup for <team> - start the standup for <team>
cancel standup - cancel the current standup
next - say when your updates for the standup is done
skip <who> - skip someone when they're not available
[Thu Apr 30 2015 15:44:49 GMT+0200 (CEST)] DEBUG Received message: 'victor is a member of devs' in channel: victor, from: victor

Any pointers to what's going on? Am I using it wrong?

Also, took a look in the code and there doesn't seems to be any matching when adding a team member...

@rockerhieu
Copy link

Yeah it doesn't seem to work.

@rockerhieu
Copy link

@miyagawa is this project still active?

@martinb3
Copy link

@rockerhieu FWIW I've been maintaining this fork and merging in PRs. https://github.com/martinb3/hubot-standup-ng

This project seems to go dormant for a while and then have bursts of activity like once a year.

@rockerhieu
Copy link

@martinb3 did you success to get hubot-standup work? I tried <who> is a member of <team> command but couldn't get it to work. The source code also doesn't contain any parts that process <who> is a member of <team>.

@martinb3
Copy link

@rockerhieu It's part of hubot itself, at least it was when I started using it. It's an auth plugin now, it looks like.

@rockerhieu
Copy link

Gotcha. I will take sometime to implement it.

On Tue, Jul 28, 2015 at 7:07 PM, Martin Smith [email protected]
wrote:

@rockerhieu https://github.com/rockerhieu It's part of hubot itself, at
least it was
https://github.com/github/hubot-scripts/blob/master/src/scripts/auth.coffee
when I started using it. It's an auth plugin now
https://github.com/hubot-scripts/hubot-auth, it looks like.


Reply to this email directly or view it on GitHub
#10 (comment)
.

Hieu Rocker

@thatarchguy
Copy link
Contributor

I added #14 to work with hubot-auth

@chriskol
Copy link

chriskol commented Jun 16, 2016

I'm having this issue still actually with my hubot, bianca

chris [7:57 PM]
bianca what roles do i have

biancaBOT [7:57 PM]
@chris: chris has the following roles: admin, lead.

[8:00]
bianca chris is a member of lead

[8:02]
bianca standup for lead

biancaBOT [8:02 PM]
Oops, can't find anyone with 'a lead member' role!

chris [8:20 PM]
bianca who has lead role

biancaBOT [8:20 PM]
@chris: The following people have the 'lead' role: chris, mark

chris [8:21 PM]
bianca standup for lead

biancaBOT [8:21 PM]
Oops, can't find anyone with 'a lead member' role!

I'm using hubot-auth but even using 'is a member' didn't work. It seems to know what roles I have but can't start a standup with members of it? I'd post a debug log but tbh I'm a newbie and don't know how like OP did. Is it an issue with what's inside the quotes in that it's looking for 'a lead member' instead of 'lead'? It would seem the proper way to emphasize the role would be "Oops, can't find anyone with a 'lead' member role!"

Not sure if it's related but hubot-auth's "hubot list assigned roles" command does nothing...

@chriskol
Copy link

I fixed my issue because the latest version of hubot-auth and hubot-standup didn't reflect what was in the repo. Switched my package dependencies to pull directly from the repo instead of latest version and it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants