Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller preferences doesn't handle unsaved mapping change correctly #14220

Open
ronso0 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #14234
Open

Controller preferences doesn't handle unsaved mapping change correctly #14220

ronso0 opened this issue Jan 24, 2025 · 1 comment · May be fixed by #14234
Labels
Milestone

Comments

@ronso0
Copy link
Member

ronso0 commented Jan 24, 2025

Bug Description

  • go to Preferences -> YourController -> Inputs
  • add a new control (whatever, empty entry suffices), DON'T APPLY
  • close window
  • Main Window is shown
  • attempt to open Preferences
    = "Mapping has been edited. Save Yes/No" dialog

Version

2.5

OS

No response

@ronso0 ronso0 added the bug label Jan 24, 2025
@ronso0
Copy link
Member Author

ronso0 commented Jan 26, 2025

Oh, this happens only when closing with the X window button or hotkey ([close window] or Esc).
Base class preferencespage has a virtual hideEvent() and some pages override that, eg. DlgPrefLibrary.

I'll simply install the same for the controller page.
(slight downside: event is fired when the window is already hidden)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant