-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display MIDI Through device in non-developer mode #8356
Comments
Commented by: rryan The reason we removed it is that:
So I would suggest adding significant distinguishing UI to the through device that explains what it is and how to use it -- don't just remove the "if developer" preventing it from being shown :). |
Commented by: Pegasus-RPG Very good points, thank you. (The phantom input would only happen if the Through device was enabled, correct? E.g. just displaying it isn't a problem?) |
Commented by: rryan Yep, only when enabled. Though users did get stuck in a state where we auto-enable it on startup so Mixxx crashed at startup. |
Commented by: rryan (i.e. if they enable it once we auto-enabled it again on next boot) |
Commented by: markusb Just struggled with this again when coming back to Mixxx. I find developer mode overkill to enable midi through. Could we have a checkbox in the Controller preferences section which enables midi through after a restart ? This way it does not get enabled to protect beginners, but if you know what you are doing you can enable it there. |
Commented by: ronso0 Can MIDI trough with an command line option "--midiThrough" |
Commented by: Be-ing How about adding a checkbox in the preferences that exposes it? I think that would be a good balance between making it easy to use for people who want it and not misleading users who shouldn't be using it. |
Commented by: ronso0 btw there may occur many issues when loading a 'regular' controller mapping to the the Through device, like samplers playing on startup and event loops that crash Mixxx. |
Commented by: toszlanyi Hi guys - any chance a checkbox or --midiThrough option will be added? I also connect QLC+ and by default running the --developer option. This isn't ideal for everyday use. Thanks a lot! |
Commented by: daschuer I think it is all about finding a contributor who has interests to propose a Pull Request. |
Commented by: toszlanyi I have interest and would like to change the code, already looked into the task providing the info that ronso shared in https://mixxx.discourse.group/t/using-linux-midi-through-port-0-as-a-controller/21047/5 but I have no idea how to add that --midiThrough option in there. Another point today was that the sources are not compiling. cmake always stops at the point ... tried with main and latest 2.3 branch Scanning dependencies of target QtScriptByteArray So i believe for now the effort is not worth and i keep running Mixxx with --developer option as default. Would be still happy if you can guide me to add --midiThrough as option and would send a PR accordingly |
Commented by: daschuer Did you update to the latest version of main or 2.3? Maybe it helps also to delete /home/OsZ/Entwicklung/MIXXX/mixxx/build/keyfinder-prefix If the issue still exists, you can disable keyfinder by |
Commented by: daschuer The new Flag can be added here: mixxx/src/util/cmdlineargs.cpp Line 107 in c3030b8
Than follow the --controllerDebug or --@feveloper implementation to pipe the info into the code where the midi Through port is hidden |
Commented by: Be-ing IMO adding a new command line option would be almost pointless. You may as well keep using --developer. Adding an option somewhere in the preferences GUI would be better. |
Commented by: markusb Agree that adding a new command line option is not a great solution. That implies that the user has to change the desktop shortcuts manually to invoke Mixxx with this enabled. It is also likely that the change there would be lost with the next update. A checkbox to expose this is way better ! |
Commented by: ronso0 I can confirm #2 that loading existing controller scripts for the MIDI Through controller. Therefore I propose to add the command line switch first so experienced users can test it and we can collect feedback. After we have all issues sorted we can continue to add it to the Preferences incl. additional safety guards for restarts in case a loaded mapping locks up Mixxx (happened to me).
IMO users that dare to change app launchers are also capable to a) to it again after an update or b) create an additional launcher 'Mixxx MIDI Through' in the first place. |
Commented by: ronso0
There is a difference in performance. |
Commented by: eddsalkield I submitted a PR to add a --midiThrough argument. Comments appreciated! |
Reported by: Pegasus-RPG
Date: 2015-12-03T17:28:19Z
Status: In Progress
Importance: Low
Launchpad Issue: lp1522505
Tags: midi
There is a use case for regular users having access to the MIDI Through devices: controlling lighting software. There needs to be a way to enable them without engaging full developer mode.
The text was updated successfully, but these errors were encountered: