Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make navigational shortcuts visible #39

Open
1 of 2 tasks
wearhere opened this issue May 21, 2018 · 2 comments
Open
1 of 2 tasks

Make navigational shortcuts visible #39

wearhere opened this issue May 21, 2018 · 2 comments
Labels
enhancement New feature or request
Milestone
1.0

Comments

@wearhere
Copy link
Contributor

wearhere commented May 21, 2018 •
edited
Loading

  • In the main view, say that you can double-click or press Enter to open logs
  • In detail view, say that you can press Esc to close logs
@wearhere wearhere added the enhancement New feature or request label May 21, 2018
@wearhere wearhere added this to the 1.0 milestone May 21, 2018
@wearhere
Copy link
Contributor Author

In detail view we can add to ProcessControls.

In the main view we should probably refactor ProcessControls to reuse the presentation (but not the behavior, since the table will handle that interaction).

wearhere added a commit that referenced this issue May 26, 2018
@wearhere
Add navigational shortcut to process controls
fb2b5c8 
We already handled Escape to close the process details, but now we tell the
user that in case they’re confused.

A cool side effect of refactoring the controls to be derived from props is that
the stop/start toggle’s label will update to show which one is selected.

Refs #39.
@wearhere
Copy link
Contributor Author

wearhere commented Oct 4, 2018 •
edited
Loading

I'm not sure I feel super strongly about documenting double-clicking / pressing Enter, I feel like that's pretty obvious as the central action of the app / something that someone would pick up from the README? (And if we were to document that, should we document using the arrow keys and typeahead search too?)

But the process table could easily add such shortcuts using the new command menu and command set APIs introduced in #72. We might need to alter how the menu displays the command descriptions since these commands wouldn't have single-key triggers, but that'd be minor.

We can revisit before the 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@wearhere