Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ecommerce_discount model for MITxOnline #566

Closed
1 task
rachellougee opened this issue Feb 15, 2023 · 0 comments · Fixed by #567
Closed
1 task

Update ecommerce_discount model for MITxOnline #566

rachellougee opened this issue Feb 15, 2023 · 0 comments · Fixed by #567
Assignees
@abeglova

Comments

@rachellougee
Copy link
Contributor

rachellougee commented Feb 15, 2023 •
edited
Loading

User Story

The source column for_flexible_pricing from MITxOnline ecommerce_discount model is renamed topayment_type in mitodl/mitxonline#1390. Our staging model ecommerce_discount will need to be updated for that change

Description/Context

We currently have a dbt test to ensure the source column exists, but we probably should make sure it error instead of just warns when the source column changes. This might need to involve working with DevOps to have it setup on production pipeline

Acceptance Criteria
@abeglova abeglova self-assigned this Feb 15, 2023
@abeglova abeglova mentioned this issue Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abeglova abeglova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

discount_source mitodl/ol-data-platform
2 participants
@abeglova @rachellougee