Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Playwright for alternative to eval bundle #367

Open
pmalacho-mit opened this issue Jun 21, 2024 · 0 comments
Open

Use Playwright for alternative to eval bundle #367

pmalacho-mit opened this issue Jun 21, 2024 · 0 comments
Assignees

Comments

@pmalacho-mit
Copy link
Collaborator

Currently, there is a sketchy aspect of the bundling process which requires executing an extensions bundle using the eval function. In addition to this being sketchy, it also can cause issues as the execution environment is node, since the bundling process is being run by node.

(NOTE: This step is necessary to surface the extension details of a given extension class -- this works because the mixin functions that define an extension class are executed immediately, as opposed to when an extension instance is instantiated)

This fact is making it difficult for @mayarajan3 to use a library like magenta in her extension.

Here's the current code that handles this: https://github.com/mitmedialab/prg-extension-boilerplate/blob/dev/extensions/scripts/bundles/plugins.ts#L207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants