From c09e9cfe31d7deabb55d39e0a81af4a47291e01e Mon Sep 17 00:00:00 2001 From: Horea Porutiu Date: Tue, 19 Mar 2024 16:33:48 +0100 Subject: [PATCH] Update app manifest terms banner (#269) * updating app manifest and README for AWS examples --- examples/terms-modal-banner-dynamodb/README.md | 6 +++--- examples/terms-modal-banner-dynamodb/app-manifest.yaml | 8 ++++++++ examples/terms-modal-banner-s3/README.md | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 examples/terms-modal-banner-dynamodb/app-manifest.yaml diff --git a/examples/terms-modal-banner-dynamodb/README.md b/examples/terms-modal-banner-dynamodb/README.md index 08686c522..46dc3b65e 100644 --- a/examples/terms-modal-banner-dynamodb/README.md +++ b/examples/terms-modal-banner-dynamodb/README.md @@ -66,14 +66,14 @@ Once you have finished all of the steps related to AWS in the [developer tutoria 1. In your new Miro app settings, add in the `App URL`. It should end with `webassets/app.html`. 2. Open the [app manifest editor](https://developers.miro.com/docs/manually-create-an-app#step-2-configure-your-app-in-miro) by clicking **Edit in Manifest**. \ - In the app manifest editor, configure the app as follows ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Mine is just shown as an example and then click save: + In the app manifest editor, configure the app as follows ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Your `sdkUri` will be the public endpoint to your app.html file. Mine is just shown as an example so make sure to change it to point to your `app.html file` and then click save: ```yaml # See https://developers.miro.com/docs/app-manifest on how to use this -appName: s3-modal-banner +appName: dynamodb-modal-banner sdkVersion: SDK_V2 sdkUri: >- - https://s3-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html + https://dynamodb-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html scopes: - identity:read ``` diff --git a/examples/terms-modal-banner-dynamodb/app-manifest.yaml b/examples/terms-modal-banner-dynamodb/app-manifest.yaml new file mode 100644 index 000000000..99943b789 --- /dev/null +++ b/examples/terms-modal-banner-dynamodb/app-manifest.yaml @@ -0,0 +1,8 @@ +# See https://developers.miro.com/docs/app-manifest on how to use this +# make sure to replace the sdkUri with the correct URL (it will be different for each deployment) +appName: dynamodb-modal-banner +sdkVersion: SDK_V2 +sdkUri: >- + https://dynamodb-miro-terms-banner-12345.s3.amazonaws.com/webassets/app.html +scopes: + - identity:read diff --git a/examples/terms-modal-banner-s3/README.md b/examples/terms-modal-banner-s3/README.md index 249a8bd61..ff3eb287e 100644 --- a/examples/terms-modal-banner-s3/README.md +++ b/examples/terms-modal-banner-s3/README.md @@ -65,7 +65,7 @@ Once you have finished all of the steps related to AWS in the [developer tutoria 1. In your new Miro app settings, add in the `App URL`. It should end with `webassets/app.html`. 2. Open the [app manifest editor](https://developers.miro.com/docs/manually-create-an-app#step-2-configure-your-app-in-miro) by clicking **Edit in Manifest**. \ - In the app manifest editor, configure the app as follows ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Mine is just shown as an example and then click save: + In the app manifest editor, configure the app as follows ⚠️ Note: you will need to change your sdkUri to be your app.html which is hosted in the `webassets` folder of your S3 bucket. Your `sdkUri` will be the public endpoint to your app.html file. Mine is just shown as an example so make sure to change it to point to your `app.html file` and then click save: ```yaml # See https://developers.miro.com/docs/app-manifest on how to use this