Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible v3 of bunyan-cloudwatch #21

Closed
amekkawi opened this issue Feb 15, 2017 · 5 comments
Closed

Possible v3 of bunyan-cloudwatch #21

amekkawi opened this issue Feb 15, 2017 · 5 comments

Comments

@amekkawi
Copy link

Thanks for the great library. I've recently rewritten bunyan-cloudwatch to overcome a few issues I encountered:

I also added support for recovering from AWS errors and followed AWS limts on PutLogEvents (i.e. max 10000 log events and 1 MB per call) just to be safe.

Since I had a hard deadline I've published it as cwlogs-writable.

However, I kept the constructor options (and methods to a degree) the same so it could act as a drop in replacement of bunyan-cloudwatch.

If you're still maintaining this library, I'd love to collaborate to try to work these changes into bunyan-cloudwatch.

Thanks again!

@jerroydmoore
Copy link

Thanks for people to your forked copy. I'm not sure if this project is currently maintained, but I have run into issues using bunyan-cloudwatch. I was wondering why you did not submit a PR? Also, I've taken a look at your commit history, and it appears you've erased this project's git history. Any reason why you've done this?

@amekkawi
Copy link
Author

cwlogs-writable is a complete rewrite of bunyan-cloudwatch and not a fork, so the commit history isn't shared.

To make it as much of a drop-in replacement as possible, I used the same names for options, properties and methods.

However, since it is a rewrite a simple PR wouldn't work. I opened this issue in case some of the changes/fixes implemented in cwlogs-writable could be ported over to bunyan-cloudwatch.

@jerroydmoore
Copy link

Thanks for the clarification!

@mirkokiefer
Copy link
Owner

@amekkawi I have a bit more bandwith for open source work in the next while - would be happy to work on improving this library.

@amekkawi
Copy link
Author

Hi @mirkokiefer sorry I missed your response. Still have some bandwidth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants