-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible v3 of bunyan-cloudwatch #21
Comments
Thanks for people to your forked copy. I'm not sure if this project is currently maintained, but I have run into issues using bunyan-cloudwatch. I was wondering why you did not submit a PR? Also, I've taken a look at your commit history, and it appears you've erased this project's git history. Any reason why you've done this? |
cwlogs-writable is a complete rewrite of bunyan-cloudwatch and not a fork, so the commit history isn't shared. To make it as much of a drop-in replacement as possible, I used the same names for options, properties and methods. However, since it is a rewrite a simple PR wouldn't work. I opened this issue in case some of the changes/fixes implemented in cwlogs-writable could be ported over to bunyan-cloudwatch. |
Thanks for the clarification! |
@amekkawi I have a bit more bandwith for open source work in the next while - would be happy to work on improving this library. |
Hi @mirkokiefer sorry I missed your response. Still have some bandwidth? |
Thanks for the great library. I've recently rewritten bunyan-cloudwatch to overcome a few issues I encountered:
time
prop removed from bunyan JSON (No timestamp in Clouwatch logs #17)I also added support for recovering from AWS errors and followed AWS limts on PutLogEvents (i.e. max 10000 log events and 1 MB per call) just to be safe.
Since I had a hard deadline I've published it as cwlogs-writable.
However, I kept the constructor options (and methods to a degree) the same so it could act as a drop in replacement of bunyan-cloudwatch.
If you're still maintaining this library, I'd love to collaborate to try to work these changes into bunyan-cloudwatch.
Thanks again!
The text was updated successfully, but these errors were encountered: