Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return in async functions? #18

Open
quocvu opened this issue Jul 21, 2016 · 0 comments
Open

return in async functions? #18

quocvu opened this issue Jul 21, 2016 · 0 comments

Comments

@quocvu
Copy link

quocvu commented Jul 21, 2016

I see few return statements in async functions.

For example https://github.com/mirkokiefer/bunyan-cloudwatch/blob/master/index.js#L102, IMO the callback should be called with an error as argument because this method already returned a value upon stating (not finishing) the execution of cloudwatch.createLogGroup().

Same comment on getSequenceToken() and _writeLogs() function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quocvu