Merge pull request #21 from miqwit/bugfix/errors-as-exceptions

raise an exception when Error occurs, like TypeError
miqwit · Jan 27, 2023 · 9d97649 · 9d97649
2 parents c273923 + ac53949
commit 9d97649
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/Controller/ErnParserController.php b/src/Controller/ErnParserController.php
@@ -772,10 +772,16 @@ public function parse(string $file_path) {
 
     // Parse XML now
     while ($data = fread($fp, 4096)) {
-      if (!xml_parse($this->xml_parser, $data, feof($fp))) {
+      try {
+        if (!xml_parse($this->xml_parser, $data, feof($fp))) {
+          throw new XmlParseException(sprintf("XML Error: %s at line %d\n",
+                          xml_error_string(xml_get_error_code($this->xml_parser)),
+                          xml_get_current_line_number($this->xml_parser)));
+        }
+      } catch (\Error $er) {
         throw new XmlParseException(sprintf("XML Error: %s at line %d\n",
-                        xml_error_string(xml_get_error_code($this->xml_parser)),
-                        xml_get_current_line_number($this->xml_parser)));
+                          $er->getMessage(),
+                          $er->getLine()));
       }
     }