New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong binary prefix #11

Open

Zipdox2 opened this issue May 9, 2023 · 2 comments · May be fixed by #13

Zipdox2 commented May 9, 2023

You're calling them MB but allocating MiB.

1 MB = 1000000 bytes
1 MiB = 1048576 bytes

Please use the correct prefixes in your documentation.

https://en.wikipedia.org/wiki/Byte#Multiple-byte_units

Owner

mintexists commented May 11, 2023

Hi ✨

Would you be able to make a pull request fixing this issue? 📦

Thank you 💯 💯

Zipdox2 linked a pull request

that will close this issue

Use correct binary prefixes #13

Open

Author

Zipdox2 commented May 16, 2023

Will you merge it then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment