Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(UI): dropdowns can drop out of view #60

Open
eladzlot opened this issue Nov 10, 2016 · 4 comments
Open

bug(UI): dropdowns can drop out of view #60

eladzlot opened this issue Nov 10, 2016 · 4 comments
Assignees

Comments

@eladzlot
Copy link
Contributor

eladzlot commented Nov 10, 2016

maybe right isn't working correctly?

screen shot 2016-11-09 at 11 15 57 am

@eladzlot eladzlot self-assigned this Nov 10, 2016
@eladzlot
Copy link
Contributor Author

eladzlot commented Nov 10, 2016

@baranan
It is not trivial to make the dropdown automatically choose the correct direction to open.
Is the "resize sidebar" option (#42) enough to solve this for us, or should we invest in automating this?

@baranan
Copy link
Contributor

baranan commented Nov 10, 2016

  1. Can you add a default width that will still show all the buttons on
    small screens? In other words, in my view the problem is that the widths of
    the section do not dynamically change to allow a reasonable view in small
    screens.
  2. In another issue (
    Copy files from a different study #62), I
    suggested using two rows of buttons. That might also help prevent this
    problem.

On Thu, Nov 10, 2016 at 10:57 AM, eladzlot [email protected] wrote:

@baranan https://github.com/baranan
It is not trivial to make the dropdown automatically choose the correct
direction to open.
Is the "resize sidebar" option enough to solve this for us, or should we
invest in automating this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AED1VxOF_k9go7us_c5cMPSmFzKC9Lwdks5q8tyEgaJpZM4KuVDb
.

@eladzlot
Copy link
Contributor Author

You can see that the buttons are already in two rows in the screen cap, so that won't help.
The problem is not a function of screen size, but of sidebar size. I don't want the sidebar any bigger by default so that we have the maximum possible editor frame.
The proper solution is to have the dropdown open to the right instead of to the left in smaller screens (Though it doesn't look as good). or maybe I can play some more with the layout, like so:

screen shot 2016-11-10 at 11 20 06 am

@baranan
Copy link
Contributor

baranan commented Nov 12, 2016

I'm not sure what the image is showing. It doesn't look good, right? Perhaps on small screens you can use smaller font for the left pane?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants