Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.23 iterator #88

Open
FlowingSPDG opened this issue Sep 2, 2024 · 1 comment
Open

Support Go 1.23 iterator #88

FlowingSPDG opened this issue Sep 2, 2024 · 1 comment

Comments

@FlowingSPDG
Copy link

Hi, thank you for maintaining nice project!

Some Go 1.23 adds official iterator(iter.Seq), I think this package can also support itas well.

I'll make a PR once I got time to work on this.

@klauspost
Copy link
Collaborator

No problem. Simple rules:

A) No API breaking.
B) Guard behind go1.23 build tags, so Go 1.21 and 1.22 will work.
C) Reasonable documentation and tests (ie "none" will not be accepted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants