Remove govulncheck as a pre-requirement to run all other functional tests #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests. I think it is OK to keep that test as failed, but this should not prevent other functional tests from keep running and notify us on a potentially introduced bug. Signed-off-by: pjuarezd <[email protected]>
harshavardhana
previously approved these changes
Jun 28, 2024
Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
pjuarezd
requested review from
harshavardhana,
ramondeklein,
cniackz,
shtripat,
jiuker,
allanrogerr,
cesnietor and
dvaldivia
jiuker
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is OK to keep that test as failed, but this should not prevent other functional tests from running and notify us on a potentially introduced bug.