Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart ignores tenant.configSecret.existingSecret=true #2325

Closed
coffee-time-design opened this issue Sep 24, 2024 · 3 comments
Closed

Helm Chart ignores tenant.configSecret.existingSecret=true #2325

coffee-time-design opened this issue Sep 24, 2024 · 3 comments

Comments

@coffee-time-design
Copy link

coffee-time-design commented Sep 24, 2024

In a recent release, tenant seems to not accept an existing secret for the MinIO root credentials.

Expected Behavior

I provide Helm the following values file:

tenant:
  configSecret:
    existingSecret: true

Create the following file:
echo -e "export MINIO_ROOT_USER=${RANDOM_USER}\nexport MINIO_ROOT_PASSWORD=${RANDOM_PASSWORD}" > config.env
Create the following secret:
kubectl create secret generic myminio-env-configuration --from-file=config.env=config.env -n tenant

I expect helm chart to install and these to be the new credentials of the root user.

Current Behavior

I get the following error:
Error: UPGRADE FAILED: Unable to continue with update: Secret "myminio-env-configuration" in namespace "tenant" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "tenant"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "tenant"

If i make those changes (add annotations), the root user is now as per the default chart values as it changes the secret:

minio
minio123

Possible Solution

Something must have changed in a previous release that causes this to no longer work, as it was working, perhaps this change could be rolled back?

Steps to Reproduce (for bugs)

as above

Your Environment

OS Ubuntu 22.04
K3S
Latest versions of Operator and Tenant using Helm.

@ramondeklein
Copy link
Contributor

Already fixed with #2299 (not released yet). Will be released in the next version...

@coffee-time-design
Copy link
Author

@ramondeklein many thanks and apologies for not picking up that this was already in motion.

@sathieu
Copy link
Contributor

sathieu commented Sep 26, 2024

@ramondeklein Any ETA for new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants