Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use full available freeCapacity of a drive #1792

Closed
zeph opened this issue Sep 27, 2023 · 2 comments
Closed

use full available freeCapacity of a drive #1792

zeph opened this issue Sep 27, 2023 · 2 comments

Comments

@zeph
Copy link

zeph commented Sep 27, 2023

Is your feature request related to a problem? Please describe.
you can fast forward skip to the bottom of this ticket for the root of this request minio/directpv#857 (comment)

from the WebUI of the MinIO Operator I was expecting to size the Tenant PVCs to get the maximum available capacity of each drive on my setup... but several things prevent it... 1st of all the assumption that since I had 25 GiB drives I could put that as a value in the Tenant creation wizard... wrong, I always need to be providing a value as close as possible but lower of the freeCapacity of a drive

Describe the solution you'd like
...the best would be a simple flag, that magically pre-fills such value with the max allocatable disk size

Describe alternatives you've considered
At least to be able to put a value with a digit after a dot... not only 25 GiB for instance but also 24.999 GiB
(possible on Tenant creation, but not allowed on the Pool editing UI once the Tenant is already created)

Additional context
wizard
in the above you can see the trick of adding .999 to the setup


editing the above is the pool editing
field_control but if I try to mod the decimals... it does not allow me to add em
@jiuker jiuker added enhancement New feature or request and removed triage labels Sep 28, 2023
@jiuker jiuker added out of scope and removed enhancement New feature or request labels Oct 8, 2023
@jiuker
Copy link
Contributor

jiuker commented Oct 8, 2023

We can't get the maximum available capacity for K8S didn't support. If you have any thoughts about this, let's discuss that.

@jiuker jiuker closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
@zeph
Copy link
Author

zeph commented Dec 15, 2023

@jiuker I'm in the implementation phase of this at a customer, and last week I exactly stumbled on this again... since my way of proceeding was associating a specific label to a set of drives, and since on creation tenant wizard I do specify a storage class name... exactly selecting such, what prevents you from talking for instance with directpv and deduct that? (I'm missing the complete picture, obviously... which u have, I assume... does this needs to be as generic as possible even talking to storage providers that are not directpv? I assume it might be the case)

because my way of proceeding at this stage was attempting to take the value in bytes that directpc discover gives me in the drives.yaml ...compute approximately a 99.9% of it, dividing then by (1024^3) I get the value I want in Gibibytes (which is what u use, as integer, after the wizard creation, if i got to change the pool if the PVCs are not allocating accordingly or if too much spare space if waster per drive)

I instead have to take such value, and even if I'm giving you on the UI the topology, I have to compute the total capacity by x host x drives give u the total in the wizard... seems a bit, inconsistent, no? ...why don't you simply ask the topology and compute the value of total capacity from the available drives on the directpv available info yourself?

  1. you ask me the topology (amount of hosts, racks, drives per host to use - hypothesis)
  2. you see the storage class, you can tell me back: you have these amount of drives of this size
  3. i click and confirm

instead I'm spending my time deleting all the PVCs resources, adjust the value on the pool in the WebUI, delete the sts, wait for the new PVCs with the new value to attempt to allocate again (in the hope of having guessed the max value the right way)... repeat as much as ... (not nice)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants