Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--version does not return version #1768

Closed
JakobPetersson opened this issue Sep 11, 2023 · 5 comments
Closed

--version does not return version #1768

JakobPetersson opened this issue Sep 11, 2023 · 5 comments
Assignees

Comments

@JakobPetersson
Copy link

Since 5.0.0 the --version flag does not return the version of minio-operator.
It only returns:

minio-operator version (dev) - (dev)

Expected Behavior

To print out the minio-operator version.

Current Behavior

Since 5.0.0 the minio-operator executable only outputs (dev)

Steps to Reproduce (for bugs)

  1. docker run --rm quay.io/minio/operator:v4.5.8 /minio-operator --version (Works)
  2. docker run --rm quay.io/minio/operator:v5.0.0 --version (Only outputs dev)
  3. docker run --rm quay.io/minio/operator:v5.0.1 --version (Only outputs dev)
  4. docker run --rm quay.io/minio/operator:v5.0.2 --version (Only outputs dev)
  5. docker run --rm quay.io/minio/operator:v5.0.3 --version (Only outputs dev)
  6. docker run --rm quay.io/minio/operator:v5.0.4 --version (Only outputs dev)
  7. docker run --rm quay.io/minio/operator:v5.0.5--version (Only outputs dev)
  8. docker run --rm quay.io/minio/operator:v5.0.6--version (Only outputs dev)
  9. docker run --rm quay.io/minio/operator:v5.0.7--version (Only outputs dev)
  10. docker run --rm quay.io/minio/operator:v5.0.8--version (Only outputs dev)

Regression

5.0.0

@harshavardhana
Copy link
Member

Yeah this is expected since this information is not embedded into operator binary, since we don't really care much for that instead we rely on the container image.

But for consistency sake we can add it.

@JakobPetersson
Copy link
Author

JakobPetersson commented Sep 11, 2023

Ok, that is very reasonable.

Another aspect that seems to be connected to this that the(dev)-value ends up in env MINIO_OPERATOR_VERSION in the tenant.

I do not know where this env variable is used. But if it is hardcoded do (dev) it could probably be removed.

@harshavardhana
Copy link
Member

Yeah that is wrong and we should fix that @JakobPetersson

@harshavardhana
Copy link
Member

This was introced as a regression when operator console moved from console repo #1769

@harshavardhana
Copy link
Member

fixed by #1769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants