fix: panic when remove mutli pools (#2215)

* fix: panic when remove mutli pools fix: panic when remove mutli pools * apply suggestion apply suggestion --------- Co-authored-by: jiuker <[email protected]>
minio · Jul 16, 2024 · ccbdd2c · ccbdd2c
1 parent 7f95174
commit ccbdd2c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/controller/decomission.go b/pkg/controller/decomission.go
@@ -90,22 +90,25 @@ func (c *Controller) checkForPoolDecommission(ctx context.Context, key string, t
 		// This means we are attempting to remove a "pool", perhaps after a decommission event.
 		var poolNamesRemoved []string
 		var initializedPool miniov2.Pool
-		for i, pstatus := range tenant.Status.Pools {
+		var poolStatus []miniov2.PoolStatus
+		for _, pstatus := range tenant.Status.Pools {
 			var found bool
 			for _, pool := range tenant.Spec.Pools {
 				if pstatus.SSName == tenant.PoolStatefulsetName(&pool) {
 					found = true
 					if pstatus.State == miniov2.PoolInitialized {
 						initializedPool = pool
 					}
-					continue
+					break
 				}
 			}
 			if !found {
 				poolNamesRemoved = append(poolNamesRemoved, pstatus.SSName)
-				tenant.Status.Pools = append(tenant.Status.Pools[:i], tenant.Status.Pools[i+1:]...)
+			} else {
+				poolStatus = append(poolStatus, *pstatus.DeepCopy())
 			}
 		}
+		tenant.Status.Pools = poolStatus
 
 		var restarted bool
 		// Only restart if there is an initialized pool to fetch the new args.