Fix bug due to empty ImagePullSecret (#138)

Set ImagePullSecret only if not empty. Ref: kubernetes/kubernetes#85332 Signed-off-by: Ritesh H Shukla <[email protected]>
minio · Jun 4, 2020 · bd1d623 · bd1d623
1 parent 4444708
commit bd1d623
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/resources/statefulsets/minio-statefulset.go b/pkg/resources/statefulsets/minio-statefulset.go
@@ -361,7 +361,6 @@ func NewForMinIO(mi *miniov1.MinIOInstance, serviceName string) *appsv1.Stateful
 				Spec: corev1.PodSpec{
 					Containers:         containers,
 					Volumes:            podVolumes,
-					ImagePullSecrets:   []corev1.LocalObjectReference{mi.Spec.ImagePullSecret},
 					RestartPolicy:      corev1.RestartPolicyAlways,
 					Affinity:           mi.Spec.Affinity,
 					SchedulerName:      mi.Scheduler.Name,
@@ -373,6 +372,11 @@ func NewForMinIO(mi *miniov1.MinIOInstance, serviceName string) *appsv1.Stateful
 		},
 	}
 
+	// Address issue https://github.com/kubernetes/kubernetes/issues/85332
+	if mi.Spec.ImagePullSecret.Name != "" {
+		ss.Spec.Template.Spec.ImagePullSecrets = []corev1.LocalObjectReference{mi.Spec.ImagePullSecret}
+	}
+
 	if mi.Spec.VolumeClaimTemplate != nil {
 		pvClaim := *mi.Spec.VolumeClaimTemplate
 		name := pvClaim.Name