fix python3.13 leap day parsing warning in time.from_http_header() #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Oct 26, 2024
minio/timeutils.py
Outdated
There was a problem hiding this comment.
Pleasse stick to the fix and unnecessary changes break backward compatibilities.
There was a problem hiding this comment.
sorry for delay, done, i was little too enthusiastic at first (hope you don't mind), let's keep the stuff as is
Signed-off-by: rafsaf <[email protected]>
rafsaf
force-pushed
the
datetime-leap-day-parsing
branch
from
ff549d0
to
7b27e14
Compare
rafsaf
changed the title
balamurugana
requested changes
Nov 6, 2024
balamurugana
reviewed
Nov 6, 2024
balamurugana
reviewed
Nov 6, 2024
balamurugana
changed the title
balamurugana
approved these changes
Nov 6, 2024
harshavardhana
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of discussion in #1451
datetime.strptime(value, "%a, %d %b %Y %H:%M:%S %Z")indeed, i created some tests (test_to_http_header_polish_locale, it will be skipped if you don't have pl locale, and i don't think it's crucial to install it in CI) to play with that and i can also see no way to do it without using some kind of locks but this would be much worse than now, and suggested fix indeed is fineHope that helps
Fixes #1451