Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing handling for colorized textures (Grass isn't green) #90

Open
randomMesh opened this issue Jan 7, 2022 · 2 comments
Open

Missing handling for colorized textures (Grass isn't green) #90

randomMesh opened this issue Jan 7, 2022 · 2 comments
Labels

Comments

@randomMesh
Copy link

randomMesh commented Jan 7, 2022

Generating a colors.txt file for MineClone2 with the dumpnodes mod yields in a brownish color (RGB 142 131 114) for mcl_core:dirt_with_grass.

See attached image, "singleplayer" literally is standing in a meadow but it looks like there's only rock.

I expect the color to be more greenish.
For example, the color for default:dirt_with_grass in the shipped colors.txt is RGB 64 111 26, which is way better.

I think the problem lies within the average_color function in util/generate_colorstxt.py

def average_color(filename):

map

@Calinou Calinou added the bug label Jan 7, 2022
@randomMesh
Copy link
Author

randomMesh commented Jan 8, 2022

In comparison, here is the same map if i replace the color for mcl_core:dirt_with_grass with the one from the shipped colors.txt. Looks like that more colors are off.

map

@sfan5
Copy link
Member

sfan5 commented Feb 9, 2022

The color generation process picks the first filename from the texture string, MCL probably has a gray texture and uses [colorize to get different shades. The script could detect this and attempt to handle it but this is just bandaid (it won't handle complex texture strings).
Seeing as Minetest Game also has some manual color adjustments I think the best fix is if MCL shipped a colors.txt for their game.

@sfan5 sfan5 changed the title Grass isn't green Missing handling for colorized textures (Grass isn't green) Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants