You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generating a colors.txt file for MineClone2 with the dumpnodes mod yields in a brownish color (RGB 142 131 114) for mcl_core:dirt_with_grass.
See attached image, "singleplayer" literally is standing in a meadow but it looks like there's only rock.
I expect the color to be more greenish.
For example, the color for default:dirt_with_grass in the shipped colors.txt is RGB 64 111 26, which is way better.
I think the problem lies within the average_color function in util/generate_colorstxt.py
In comparison, here is the same map if i replace the color for mcl_core:dirt_with_grass with the one from the shipped colors.txt. Looks like that more colors are off.
The color generation process picks the first filename from the texture string, MCL probably has a gray texture and uses [colorize to get different shades. The script could detect this and attempt to handle it but this is just bandaid (it won't handle complex texture strings).
Seeing as Minetest Game also has some manual color adjustments I think the best fix is if MCL shipped a colors.txt for their game.
sfan5
changed the title
Grass isn't green
Missing handling for colorized textures (Grass isn't green)
Apr 8, 2023
Generating a colors.txt file for MineClone2 with the
dumpnodes
mod yields in a brownish color (RGB 142 131 114) formcl_core:dirt_with_grass
.See attached image, "singleplayer" literally is standing in a meadow but it looks like there's only rock.
I expect the color to be more greenish.
For example, the color for
default:dirt_with_grass
in the shipped colors.txt is RGB 64 111 26, which is way better.I think the problem lies within the
average_color
function inutil/generate_colorstxt.py
minetestmapper/util/generate_colorstxt.py
Line 63 in 9b26d94
The text was updated successfully, but these errors were encountered: