Chest registration overrides definition fields, including inventory callbacks

[DustyBagel]

Minetest version

Minetest-5.9.0-stable

Irrlicht device

win32

Operating system and version

Windows 11 home

CPU model

No response

GPU model

No response

Active renderer

No response

Summary

I am using the allow_put node callable and it doesn't seem to be running:

default.chest.register_chest("modname:nodename", {
    --other callbacks
    allow_put = function(inv, listname, index, stack, player)
        minetest.chat_send_all("This is running")
        return stack:get_count()
    end
})

I do have a theory that this function that is connected to the allow_put callback is being overwritten by the register_chests function which can be found here:
https://github.com/minetest/minetest_game/blob/master/mods/default/chests.lua#L89

Steps to reproduce

Run test mod:
allow_put_test.zip

[appgurueu]

1. It's allow_metadata_inventory_put for nodes. allow_put is for detached inventories. Our docs could be clearer about this.
2. You are correct that default.chest.register_chest overrides a bunch of definition fields. If def.protected is truthy, allow_metadata_inventory_put will be overridden. Instead we should call the original allow handler if the protection check succeeds.

This is no engine issue however, it's a Minetest Game dehardcoding request.

[DustyBagel]

Ah, I see, the docs were confusing because the line:

• allow_put / allow_metadata_inventory_put
  implies they are the same/interchangeable.
  https://github.com/minetest/minetest/blob/master/doc/lua_api.md?plain=1#L7548
  https://github.com/minetest/minetest/blob/master/doc/lua_api.md?plain=1#L7562

The engine docs should be changed to reflect the difference between them.

Maybe we can change how defs are handled in the default.chest.register_chest function, Something like this:

default.chest.register_chest(nodename, {
    --other defs
    if def.protected then
        if def.allow_metadata_inventory_put then
            local old_func = def.allow_metadata_inventory_put
            def.allow_metadata_inventory_put = function (pos, listname, index, stack, player)
                if not default.can_interact_with_node(player, pos) then
                     return 0
                end
                old_func()
                return stack:get_count()
            end
        else
              def.allow_metadata_inventory_put = function (pos, listname, index, stack, player)
              if not default.can_interact_with_node(player, pos) then
                   return 0
              end
              return stack:get_count()
        end
    end
})