Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network race condition of versionsdb download #11

Open
ChristopherHX opened this issue Mar 20, 2021 · 0 comments
Open

Network race condition of versionsdb download #11

ChristopherHX opened this issue Mar 20, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ChristopherHX
Copy link
Member

mcpelauncher-ui-qt/archivalversionlist.cpp

Line 35 in 30209e8

if (reply->error() != QNetworkReply::NoError) {

If github sends a http redirect, it returns noerror and we end up with an empty versionsdb
@ChristopherHX ChristopherHX added the bug Something isn't working label Mar 20, 2021
ChristopherHX referenced this issue in flathub/io.mrarm.mcpelauncher Mar 20, 2021
@ChristopherHX
Fix versiondb url
b6b0755 
Why does the versiondb fallback not work in flatpak???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristopherHX