Not all the Lang will be published. #30
Closed
mjamilasfihani
started this conversation in
General
Replies: 1 comment
-
Yes, I saw it in your PR #29. Thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi! I've found some potential bug in the future, as you can see I've took some minutes to compare between the lang dirs and the attribute and not all of them was added into
$langs
.While for publishing from
publishLangFiles()
method you were loop these values first before execute the publisher. Maybe we can add new tests to make sure everything was published correctly? Thank you.Beta Was this translation helpful? Give feedback.
All reactions